Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] - PRs about Text and TextInput #10

Closed
efstathiosntonas opened this issue Jan 17, 2024 · 2 comments
Closed

[Feature] - PRs about Text and TextInput #10

efstathiosntonas opened this issue Jan 17, 2024 · 2 comments
Labels
Feature Feature request

Comments

@efstathiosntonas
Copy link
Contributor

efstathiosntonas commented Jan 17, 2024

Hi Fabrizio, thank you for this repo.

Here's a list of PRs around Text and TextInput that I managed to gather at that time.

reactwg/react-native-releases#83 (comment) (the comment with the list is hidden so expand it)

Some PRs are really old, some might be addressed in other PRs, some could be really outdated but the issue they are trying to solve might be still there.

@fabOnReact fabOnReact changed the title PRs about Text and TextInput [Feature] PRs about Text and TextInput Jan 25, 2024
@fabOnReact fabOnReact changed the title [Feature] PRs about Text and TextInput [Feature] - PRs about Text and TextInput Jan 25, 2024
@fabOnReact fabOnReact added the Feature Feature request label Jan 25, 2024
@fabOnReact
Copy link
Owner

fabOnReact commented Jan 26, 2024

I started reviewing those PRs. I merged:

I will merge the remaining PRs in 1-2 weeks. Thanks a lot

@fabOnReact
Copy link
Owner

fabOnReact commented Feb 2, 2024

Thanks @efstathiosntonas for the feedback.

  1. Many of those PRs are from Expensify.
  2. I reached the company and they told me that they will not use the library.
  3. I don't plan to add more fixes/PRs in this project.

I will now complete the project (add support for latest version of react-native and new arch) and then start working on my next project react-native-patch.

React Native Devs that want to patch react-native:

  1. they fork react-native-patch
  2. they implement the patch (for example PR Fix letters duplication with autocapitalize #29070 #16 and apply changes from PR - multiple modal on iOS #31498 #29)
  3. run yarn release

The advantages:

  • Building from source react-native takes a long time (for ex. expensify/app 30-40 min).
  • Building from source requires additional setup. This library instead just requires npm install.
  • It is not a fork of react-native. We are still using the react-native APIs like ReactEditText, but over-riding some of their methods implementation (see examples in PRs #16 and #29). We can upgrade without much trouble and use the latest react-native APIs.
  • We don't patch node_modules. There will be no merge conflict when upgrading.
  • Can be used to build new APIs based on react-native APIs (for ex. RichText)
  • The project would include extra documentation on the ReactNative APIs.
  • It is easy to migrate to a separate library (for example, doing lean core for the TextInput component), as we already build the native APIs.

I will wait for the community to start using this project and then maybe invest more time in it, but for now I don't plan on adding more fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature request
Projects
None yet
Development

No branches or pull requests

2 participants