Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMMGamePlayerFastLauncher doesn't create shortcuts for any game, but does for DMMGamePlayer. #117

Closed
Dario011 opened this issue Feb 1, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@Dario011
Copy link

Dario011 commented Feb 1, 2024

OS

Windows 10 (22H2)

Bug Description

The application does not create any shortcut to Princess Connect Re:Dive, in any of the options (Normal and UAC) to create shortcuts, but it allows me to create a shortcut to DMM Game Player with the custom token.
And if I try to create the shortcut via the "Edit Shortcut" option, it deletes the .json configuration file.

Tested with versions 5.3 (the latest up-to-date version) and 5.2.0.

Error Message

No response

Log

No response

@Dario011 Dario011 added the bug Something isn't working label Feb 1, 2024
@fa0311
Copy link
Owner

fa0311 commented Feb 2, 2024

I could not reproduce it in my environment.
Can I enable [Setting] -> [Edit Shortcut] -> [Show Debug Window] to send logs?
(Note that FastLauncher must be restarted after saving the settings)
Also, if the log contains Token, please mask it.

@Dario011
Copy link
Author

Dario011 commented Feb 2, 2024

I got to activate the mentioned options, and I already have a log (with the tokens and another IDs removed, with the [REDACTED]).

And it seems that the problem is that I get to create the shortcut, but with the name of the game in Japanese, which causes that it is not done, the syntax of the shortcut is shown in the log.

I managed to recreate the shortcut from the shortcut syntax for the Launcher, and then I got it to work, but I ALWAYS have to hit "Run as administrator".

log.txt

@fa0311
Copy link
Owner

fa0311 commented Feb 5, 2024

Thanks for providing the logs!

And it seems that the problem is that I get to create the shortcut, but with the name of the game in Japanese, which causes that it is not done, the syntax of the shortcut is shown in the log.

Is it true that I cannot create shortcuts in Japanese?
I am using Japanese Windows, so I can create them, but they may not be available in other countries.

fa0311 added a commit that referenced this issue Feb 5, 2024
DMMGamePlayerFastLauncher doesn't create shortcuts for any game, but does for DMMGamePlayer. #117

Signed-off-by: ふぁ <[email protected]>
@fa0311 fa0311 mentioned this issue Feb 5, 2024
@fa0311
Copy link
Owner

fa0311 commented Feb 5, 2024

The arbitrarily specified filename will now be used as the shortcut name if the following conditions are met.
If Japanese(cp932) is the cause of this issue, it will probably be fixed.

  • If the OS is not Japanese(cp932)
  • If the game name contains a string other than ascii

https://github.com/fa0311/DMMGamePlayerFastLauncher/pull/119/files#diff-712607c6a48a2cbcc42641ff37a30f4a479d3e8c31fde554973fdf69e1f73338R163-R171

@fa0311
Copy link
Owner

fa0311 commented Feb 7, 2024

Maybe that was fixed in v5.4.0.

@fa0311 fa0311 closed this as completed Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants