Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filereceiver component with updated functionality #186

Merged
merged 4 commits into from
Jun 23, 2023

Conversation

moh-osman3
Copy link
Contributor

@moh-osman3 moh-osman3 commented Jun 22, 2023

What does this PR do?
This PR is part 2 of #185
Adds the filereceivercomponent directly rather than using the component currently in opentelemetry-collector-contrib package.

Adding the component directly allows us to use the functionality from this open-telemetry/opentelemetry-collector-contrib#22080 open in the contrib repository. This contrib PR is taking a while to get approved so in the meantime it might be better to add these changes to start using these components to replay data in production.

Example config:

receivers:
  file:
    path: ../../gen/receiver/filereceiver/testdata/metrics.json
    compression: zstd
    format: json

Testing
Ran the cmd/otelarrowcol with the filereceiver component and successfully read from file in the desired format/compression

(cc: @jmacd)

@moh-osman3 moh-osman3 changed the title Add fileexporter component with updated functionality Add filereceiver component with updated functionality Jun 22, 2023
@moh-osman3 moh-osman3 marked this pull request as ready for review June 22, 2023 19:33
@moh-osman3 moh-osman3 force-pushed the mohosman/filereceiver-component branch from 2dabedf to 830865d Compare June 23, 2023 18:27
Copy link
Collaborator

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect this to be short-lived, as we wait for the contrib repo to accept & review this functionality. Until then, it will be nice to be able to run telemetry-generator from in-repo components. Thanks @moh-osman3

@lquerel
Copy link
Contributor

lquerel commented Jun 23, 2023

@moh-osman3 there are some conflicts to resolve that prevent to merge this PR.

@moh-osman3 moh-osman3 force-pushed the mohosman/filereceiver-component branch from 11064ba to 881e648 Compare June 23, 2023 23:41
@moh-osman3
Copy link
Contributor Author

@lquerel rebased and fixed the conflict. Thank you!

@lquerel
Copy link
Contributor

lquerel commented Jun 23, 2023

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants