-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimisations - Round 3 #108
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…06-optimization-round-3
jmacd
reviewed
Feb 17, 2023
Co-authored-by: Joshua MacDonald <[email protected]>
# Conflicts: # go.mod # go.sum
jmacd
approved these changes
Mar 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand now how schema building and transformation works at the high level. Looks good. I noticed a few places where panic
makes sense now. I filed #121 to make sure the collector won't die in case of panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a massive update of the underlying infrastructure used to encode/decode OTLP to/from OTLP Arrow messages.
In the previous version the
AdaptiveSchema
was used to dynamically adapt the schema for fields that can be either a dictionary or a primitive/binary type (e.g. Int32, String, Binary).This PR introduce a more general system called
RecordBuilderExt
(ext for extension to the standard Arrow RecordBuilder). TheRecordBuilderExt
interprets special annotations attached to the Arrow Schema of OTEL entities. There are currently 2 types of annotation supported:This modification aims to improve the performance (CPU, memory allocation, compression) of small batches (<100) and to some extent improve a bit the performance of bigger batches.
Note: On the decoder side, we treat all the fields as optional as in protobuf. Logically some fields are mandatory but in fact, at the protobuf level, nothing prevents them from being optional. A default value will be assigned to any missing field (as in pdata).
A new set of unit tests have been added to track dictionary overflow for metrics, logs, and traces.
Updated benchmark results have been included into the README.md file.