-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ANTLR4 dependencies for fasm. #1880
Conversation
Signed-off-by: Dusty DeWeese <[email protected]>
|
Signed-off-by: Dusty DeWeese <[email protected]>
1926fcc
to
32ee0a1
Compare
Signed-off-by: Dusty DeWeese <[email protected]>
I don't believe building the antlr4 runtime within the arch-defs CI is the right approach here, especially given the fact that 4 other repos will need to do the same thing. I think using a PPA to get a package or adding the dep to the litex hub conda misc are better approaches. @mithro, thoughts? |
This is a temporary fix until we have a proper package. It doesn't take long to build. |
You would have to add this temporary fix to 5 build systems, so even if it doesn't take a long time, it seems like a bad approach. |
I think this is a better solution: chipsalliance/fasm#41 |
Superseded by chipsalliance/fasm#41 |
No description provided.