Ackermann launch files #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes compile_commands.json files are copied inside the package to help linters. Ignore these files because they are user specific and not useful to track.
This commit refactor the vesc driver launch taking the nav2 bringup launch as reference. As part of the refactoring an argument to set the node logging level was added.
ValerioMagnago
commented
Mar 31, 2023
|
LGTM with one minor change. |
|
@JWhitleyWork do you have any update here? |
|
Upon closer inspection, yes, I believe we should keep the existing files. Adding more parameters to them (with default values) would also be acceptable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardize the launch file inside vesck ackermann to the one in the driver and as was done for the driver we also add a separate config file which is a parameter of the launch file so the user can give custom configuration to the launch file without the need of changing the code of this package.
I decided also to remove the old launch file but I was not sure if we should keep them for compatibility?