Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allenw/interp scalars #12

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Conversation

allen-adastra
Copy link
Contributor

Add support for scalar query points.

This isn't the most elegant way of going about it, would welcome other ideas.

I will note that currently on main, if I input a scalar as a 1d array, we fail the jax.grad test it seems.

Also increase jax version range up to 0.4.20.

@f0uriest
Copy link
Owner

Thanks for the PR! My bad for not checking for scalar inputs 😴

Looks like the tests are failing due to some deprecation warnings in newer versions of JAX, can you take a look? Also looks like some formatting/linting issues, pre-commit (yml file https://github.com/f0uriest/interpax/blob/main/.pre-commit-config.yaml) should take care of it.

@allen-adastra
Copy link
Contributor Author

Thanks for making this package! Def something that is sorely needed.

Sorted out the deprecation matter and ran the pre-commit (whoops, didn't install).

I also recently tried this new linter/formatter that has been exploding in popularity. Will say it's been a good move for me:
https://github.com/astral-sh/ruff

@codecov-commenter
Copy link

Codecov Report

Merging #12 (4bd3f51) into main (c3b1d4c) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   96.81%   96.83%   +0.01%     
==========================================
  Files           4        4              
  Lines         628      631       +3     
==========================================
+ Hits          608      611       +3     
  Misses         20       20              
Files Coverage Δ
interpax/_spline.py 97.02% <100.00%> (+0.01%) ⬆️

@f0uriest f0uriest merged commit 4160329 into f0uriest:main Nov 18, 2023
7 checks passed
@allen-adastra allen-adastra mentioned this pull request Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants