Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make popup qr codes for external links #541

Open
wants to merge 3 commits into
base: next
Choose a base branch
from
Open

Make popup qr codes for external links #541

wants to merge 3 commits into from

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Dec 10, 2024

Adds a field to enable kiosk mode for each individual room.

If kiosk mode is not enabled for the room you are in, it no longer blurs people's names.

If kiosk mode is enabled, it replaces the links in the footer with qr code popups:
image

The mode should be enabled in most rooms but can be disabled in the Strandvejen - Remote room.

@atjn atjn linked an issue Dec 10, 2024 that may be closed by this pull request
@krestenlaust
Copy link
Member

You should be careful to not repeat terminology, as stregsystem already has the app named 'kiosk' which is the screen in the Jægerstue

@krestenlaust
Copy link
Member

While it's kinda intuitive to have rooms opt-into this mode, it is kind of misunderstood imo. The stregsystem is only ever a stregsystem, it isn't meant to be opened on non-kiosk computers. I've actually considered to redirect all page loads from non-stregkiosk to fappen, but it isn't really mature enough on desktop imo

@atjn
Copy link
Contributor Author

atjn commented Dec 10, 2024

You should be careful to not repeat terminology, as stregsystem already has the app named 'kiosk' which is the screen in the Jægerstue

I see your point, but my counter point is that the screen in the jægerstue is not a kiosk and has incorrectly used the terminology for what I am adding here

@atjn
Copy link
Contributor Author

atjn commented Dec 10, 2024

While it's kinda intuitive to have rooms opt-into this mode, it is kind of misunderstood imo. The stregsystem is only ever a stregsystem, it isn't meant to be opened on non-kiosk computers. I've actually considered to redirect all page loads from non-stregkiosk to fappen, but it isn't really mature enough on desktop imo

I don't understand why it is a problem that people use the stregsystem on their own computers. But if you prefer to just use the "kiosk" solution on all pages and remove the opt-in, we can definitely do that.

@krestenlaust
Copy link
Member

krestenlaust commented Dec 10, 2024

While it's kinda intuitive to have rooms opt-into this mode, it is kind of misunderstood imo. The stregsystem is only ever a stregsystem, it isn't meant to be opened on non-kiosk computers. I've actually considered to redirect all page loads from non-stregkiosk to fappen, but it isn't really mature enough on desktop imo

I don't understand why it is a problem that people use the stregsystem on their own computers. But if you prefer to just use the "kiosk" solution on all pages and remove the opt-in, we can definitely do that.

My main issue is when people 'misuse' the stregsystem. Probably the most common case for refund is people accidentally refreshing the page with post content. It also adds a pressure to maintain the stregsystem as a website (extra work you've mainly done in your last ~15 PRs, but if you didn't do it, nobody else would). With the footer with links being one of the first features directed at the website use-case, which actually ended up disrupting the 'real' use-case.

Summarized, more bugs and unintended behavior appear, because there are more user journeys. More user journeys also requires more features = more code = more difficult to maintain. Chat me up in the hallway if I'm missing something

@atjn
Copy link
Contributor Author

atjn commented Dec 10, 2024

I understand that you want to keep the focus on the "kiosk mode" and dont want to maintain a separate mode. So I will remove the option to disable kiosk mode.

I also understand that the refresh issue is a big problem but I am working on some ideas to fix that, so I don't see that as a long-term issue.

I think that we can strike a good balance where we continue to make the stregsystem available remotely, but with limited support.

@atjn atjn changed the title Add a kiosk mode Make popup qr codes for external links Dec 11, 2024
@atjn atjn requested a review from krestenlaust December 11, 2024 06:42
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.80%. Comparing base (a02bfdb) to head (f8aede7).
Report is 3 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #541   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files          40       40           
  Lines        3809     3809           
  Branches      481      481           
=======================================
  Hits         3078     3078           
  Misses        675      675           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Footer links allow users to exit kiosk sandbox
2 participants