Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a footer #525

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Add a footer #525

merged 2 commits into from
Nov 21, 2024

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Nov 7, 2024

Add a neat little footer.

This fixes the long standing issue that our TOS is not visible: #301

I also made this because some of our themes would be much easier to make if there was a proper footer to add content to. You will se the benefit in some future PRs :)

image

@atjn atjn mentioned this pull request Nov 7, 2024
@krestenlaust
Copy link
Member

Maybe #369 can be fixed here?

@atjn
Copy link
Contributor Author

atjn commented Nov 12, 2024

@krestenlaust that sounds like a good idea, but it would require you to maintain the version number somewhere in the source code. Maybe this would be best for a separate PR where we could discuss how to set that up?

@atjn
Copy link
Contributor Author

atjn commented Nov 12, 2024

I can only find a version number in setup.py and it is not up to date. We need to figure out how to make sure it gets updated, then we need to figure out how to access it and add it to the page.

Copy link
Member

@krestenlaust krestenlaust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krestenlaust krestenlaust merged commit 3d2d2eb into next Nov 21, 2024
3 checks passed
@krestenlaust krestenlaust deleted the footer branch November 21, 2024 11:34
This was referenced Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants