Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed makefile #37

Merged
merged 4 commits into from
Jun 16, 2024
Merged

fixed makefile #37

merged 4 commits into from
Jun 16, 2024

Conversation

Mast3rwaf1z
Copy link
Member

@Mast3rwaf1z Mast3rwaf1z commented Jun 12, 2024

fixes #36

i have not checked the pdf beyond the first 10 pages, but the flag does not seem to change the output of the makefile

@mads256h
Copy link
Member

It is supposed to make the papersize A4. Check if the output is different

@Mast3rwaf1z
Copy link
Member Author

Mast3rwaf1z commented Jun 12, 2024

dvips --help says that dvips -t a4 does the same, i'd say that's good enough? edit: nvm, its not called lmao

image

@mads256h
Copy link
Member

Yeah dvipdf is a wrapper around dvips. I think dvipdf complains and then passes the options on to dvips.
Is that screenshot with or without -ta4?

@Mast3rwaf1z
Copy link
Member Author

Is that screenshot with or without -ta4?

without

@mads256h
Copy link
Member

I does fuck all then lol

@Mast3rwaf1z
Copy link
Member Author

-sPAPERSIZE=a4 seems to do the same as far as i can read, i think its a parameter passed to gs, but i'm not sure

@Mast3rwaf1z
Copy link
Member Author

waiting on #35

@mads256h
Copy link
Member

-sPAPERSIZE=a4 seems to do the same as far as i can read, i think its a parameter passed to gs, but i'm not sure

We should probably upgrade to pdflatex sometime in the future.
This stuff is pretty old, slow, and finicky.

@JakobTopholt
Copy link
Contributor

@Mast3rwaf1z Am I correct in understanding that you wanted to test it after #35 was merged?

@Mast3rwaf1z
Copy link
Member Author

Mast3rwaf1z commented Jun 16, 2024

@Mast3rwaf1z Am I correct in understanding that you wanted to test it after #35 was merged?

It's mostly so I make sure this pr doesn't break CI

Edit: it works, unless you wanna review yourself its good for merge imo

@JakobTopholt JakobTopholt merged commit ed25003 into f-klubben:main Jun 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI and makefile are inconsistent
3 participants