Fix links, dump all output files in compilation metrics page #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes to make tlparse artifacts unique, we also made it a bit harder to link to compilation artifacts from pages other than index.html. This change factors out compilationmetrics so that you can pass the entire directory into tlparse, so that each compilation metrics page wlil have all of the build products associated with that compile id directly linked.
It also allows the failures and restarts page to link correctly to the compilation metrics page, using a similar technique.
It's a bit hacky how I derive the filenames for compilation_metrics.html, but I couldn't really come up with that good of a way otherwise. We might wanna refactor later so that each file has a unique id associated with it in the FXIndexMap or something.