-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31449: Adapted TranslatablePropertyTransformer to properly handle nulls #338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we narrow it down to just Content Types? Or is this transformer used only there?
POV ping @webhdx
tests/RepositoryForms/Form/DataTransformer/TranslatablePropertyTransformerTest.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was afraid that it may have some side effects in translations of selection options, but it seems that is all alright!
Reverse transformation in
TranslatablePropertyTransformer
was adapted to properly handleContentType
andContentType's
fieldtype translatable fields when the empty value was provided in form.Original kernel PR and discussion: ezsystems/ezpublish-kernel#2988 -> closed right now.
TODO:
$ composer fix-cs
).