Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZEE-2930: Added Language obj. instance to User create/edit views #334

Merged
merged 5 commits into from
Mar 16, 2020
Merged

EZEE-2930: Added Language obj. instance to User create/edit views #334

merged 5 commits into from
Mar 16, 2020

Conversation

mateuszdebinski
Copy link
Contributor

Question Answer
Tickets EZEE-2930
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Another PR:
ezsystems/ezplatform-admin-ui#1244

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski mentioned this pull request Feb 18, 2020
Merged
2 tasks
adamwojs
adamwojs reviewed Feb 20, 2020
View reviewed changes
bundle/Controller/UserController.php Outdated Show resolved Hide resolved
bundle/Controller/UserController.php Outdated Show resolved Hide resolved
@mateuszdebinski
Added missing parameter parentLocation in createAction, changed from …
984441e 
…optional to mandatory parameters $versionNo and $language in editAction, corrected problem with permissions with multi locations
alongosz
alongosz requested changes Feb 24, 2020
View reviewed changes
bundle/Controller/UserController.php Outdated Show resolved Hide resolved
bundle/Controller/UserController.php Show resolved Hide resolved
bundle/Controller/UserController.php Outdated Show resolved Hide resolved
@alongosz alongosz changed the title EZEE-2930: Added Language class to view EZEE-2930: Added Language obj. instance to User create/edit views Feb 24, 2020
webhdx
webhdx suggested changes Feb 24, 2020
View reviewed changes
Copy link
Contributor

@webhdx webhdx left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like @alongosz is right. You should pass proper parent location.

@alongosz alongosz requested a review from webhdx March 11, 2020 08:55
@lserwatka lserwatka merged commit 68cf3c3 into 2.5 Mar 16, 2020
@lserwatka lserwatka deleted the EZEE-2930 branch March 16, 2020 14:01
@lserwatka
Copy link
Member

Please merge it up

@mateuszdebinski mateuszdebinski mentioned this pull request Mar 17, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@mateuszbieniek mateuszbieniek mateuszbieniek approved these changes

@bogusez bogusez bogusez approved these changes

@webhdx webhdx Awaiting requested review from webhdx

@mikadamczyk mikadamczyk Awaiting requested review from mikadamczyk

@adamwojs adamwojs Awaiting requested review from adamwojs

Assignees
No one assigned
Labels
Bug QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mateuszdebinski @lserwatka @adamwojs @mikadamczyk @alongosz @webhdx @ViniTou @konradoboza @mateuszbieniek @bogusez