-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZEE-2930: Added Language obj. instance to User create/edit views #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuszdebinski
requested review from
alongosz,
webhdx,
konradoboza and
mateuszbieniek
February 18, 2020 13:51
2 tasks
konradoboza
approved these changes
Feb 19, 2020
ViniTou
reviewed
Feb 20, 2020
mikadamczyk
reviewed
Feb 20, 2020
adamwojs
reviewed
Feb 20, 2020
…optional to mandatory parameters $versionNo and $language in editAction, corrected problem with permissions with multi locations
alongosz
requested changes
Feb 24, 2020
alongosz
changed the title
EZEE-2930: Added Language class to view
EZEE-2930: Added Language obj. instance to User create/edit views
Feb 24, 2020
webhdx
suggested changes
Feb 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @alongosz is right. You should pass proper parent location.
alongosz
approved these changes
Mar 11, 2020
ViniTou
approved these changes
Mar 16, 2020
mateuszbieniek
approved these changes
Mar 16, 2020
bogusez
approved these changes
Mar 16, 2020
Please merge it up |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another PR:
ezsystems/ezplatform-admin-ui#1244
Checklist:
$ composer fix-cs
)