Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31238: marked alternative image text as optional to ensure consistence with fieldtype #330

Merged
merged 1 commit into from
Dec 20, 2019
Merged

EZP-31238: marked alternative image text as optional to ensure consistence with fieldtype #330

merged 1 commit into from
Dec 20, 2019

Conversation

daavidkllr
Copy link
Contributor

Jira: https://jira.ez.no/browse/EZP-31238

According the eZ/Publish/Core/FieldType/Image/Type.php:121 (https://github.com/ezsystems/ezpublish-kernel/blob/master/eZ/Publish/Core/FieldType/Image/Type.php#L114) the alternative text is optinal.

Creating images without an alternative texts works fine using the repository services or the backend drag&drop image creation. Creating the image through the default content edit requires the alternative text is filled. The reasons for that is that the field is not marked as optional inside the form building: EzSystems\RepositoryForms\Form\Type\FieldType\ImageFieldType:40.

Already approved, discussed it in Slack:

sylvainguittard:us: 1 day ago
Hi @daavidkllr!
Sorry for the late reply. I totally agree with you, it’s inconsistent and we should fix that.
Alternative text should be optional even if the image field is required.

lib/Form/Type/FieldType/ImageFieldType.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team December 19, 2019 14:35
@micszo micszo self-assigned this Dec 20, 2019
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE v2.5.8 with diff.

@micszo micszo removed their assignment Dec 20, 2019
@lserwatka lserwatka merged commit 69a9050 into ezsystems:2.5 Dec 20, 2019
@lserwatka
Copy link
Member

@webhdx could you merge it up?

@webhdx
Copy link
Contributor

webhdx commented Dec 20, 2019

@lserwatka Done

@daavidkllr daavidkllr deleted the EZP-31238-image-fieldtype-form branch December 27, 2019 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants