Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Height fix for images #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Height fix for images #5

wants to merge 1 commit into from

Conversation

lafka
Copy link

@lafka lafka commented Sep 22, 2011

When specifying css like below, the image proportions look horrible in the toolbar itself.

input { height: 1.2em; }

This simple fix sets the responsibility to the input element back to the toolbar itself. It can be debated if it's wanted to use div#ezwt input instead, but as all input is not using images it might cause unintentional display problems other places.

@nfrp
Copy link
Contributor

nfrp commented Sep 30, 2011

Hello and thanks,

Is adding height: auto; the only required change ?

Cheers,

@lafka
Copy link
Author

lafka commented Sep 30, 2011

Hey

Yes, i only needed the height fix to make it look correct

Olav

@nfrp
Copy link
Contributor

nfrp commented Oct 3, 2011

Ok. I just applied the patch on a stock eZ Publish Community Project, and the appearance of the toolbar remains the same. I believe your fix helps in case of customization of the toolbar, which is good. I would however love to have both @cgjengedal 's and @dpobel 's quick view on this one !

Thanks Olav,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants