IBX-201: Refactored ExportParametersFactory #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
force-pushed
the
ibx-201-refactored-export-parameters-factory
branch
from
fa565b3 to
b29fefe
Compare
6 tasks
Steveb-p
reviewed
Jul 27, 2021
Steveb-p
reviewed
Jul 27, 2021
alongosz
requested changes
Jul 29, 2021
Co-authored-by: Paweł Niedzielski <[email protected]>
ViniTou
approved these changes
Aug 4, 2021
alongosz
approved these changes
Aug 4, 2021
adamwojs
approved these changes
Aug 4, 2021
Steveb-p
reviewed
Aug 4, 2021
Steveb-p
reviewed
Aug 4, 2021
Steveb-p
reviewed
Aug 4, 2021
Steveb-p
reviewed
Aug 4, 2021
Steveb-p
requested changes
Aug 4, 2021
Co-authored-by: Adam Wójs <[email protected]>
Co-authored-by: Paweł Niedzielski <[email protected]>
Steveb-p
approved these changes
Aug 6, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
ciastektk
added a commit
that referenced
this pull request
Aug 6, 2021
* IBX-201: Refactored ExportCommand * Update tests/bundle/Command/ExportCommandTest.php Co-authored-by: Paweł Niedzielski <[email protected]> * Update tests/bundle/Command/ExportCommandTest.php Co-authored-by: Paweł Niedzielski <[email protected]> * Update tests/bundle/Command/ExportCommandTest.php Co-authored-by: Paweł Niedzielski <[email protected]> * Fixed phpdoc * IBX-201: Refactored ExportParametersFactory (#68) * IBX-201: Refactored ExportParametersFactory * Update src/lib/Factory/Export/ParametersFactory.php Co-authored-by: Paweł Niedzielski <[email protected]> * Fixes after review * Fixed getMissingRequiredOptions method * Update src/lib/Exception/CredentialsNotFoundException.php Co-authored-by: Adam Wójs <[email protected]> * Update src/lib/Factory/Export/ParametersFactory.php Co-authored-by: Paweł Niedzielski <[email protected]> * Fixes after review * Used willReturnMap instead of willReturn Co-authored-by: Paweł Niedzielski <[email protected]> Co-authored-by: Adam Wójs <[email protected]> * IBX-201: Added CommandInputResolver (#69) * IBX-201: Added CommandInputResolver * Added test for CommandInputResolver * IBX-201:Fixes after refactoring (#70) * IBX-201-Fixes after refactoring * Fixes after review * Removed check option hidden * Update src/lib/Service/ExportNotificationService.php Co-authored-by: Paweł Niedzielski <[email protected]> Co-authored-by: Paweł Niedzielski <[email protected]> * Fixed phpstan errors * Fixed cs * Fixed getMissingRequiredOptions Co-authored-by: Paweł Niedzielski <[email protected]> Co-authored-by: Adam Wójs <[email protected]>
ciastektk
pushed a commit
that referenced
this pull request
Mar 16, 2022
* RSYS-3071: Fixed bugs: error label, related checkbox * Remove empty line * After CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following: #67
This PR provides refactored
ExportParametersFactoryand added new exportParametersVO.Since multimandator feature has been implemented client has possibility to add one or more configuration.
If there is only one configuration then there is no needed to pass
customerId,licenseKeyandsiteAccessparameters to run export. By default this parameters can be taken from SiteAccess configuration.For multiple configuration parameters
customerId,licenseKeyandsiteAccessare required.