Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed schema syntax error #3148

Merged
merged 1 commit into from
May 19, 2022
Merged

Fixed schema syntax error #3148

merged 1 commit into from
May 19, 2022

Conversation

glye
Copy link
Member

@glye glye commented May 18, 2022

Question Answer
JIRA issue IBX-2914
Type bug
Target eZ Platform version v2.5
BC breaks no

Syntax error: DEFAUL -> DEFAULT

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/engineering-team).

@glye glye requested a review from a team May 18, 2022 07:36
Steveb-p
Steveb-p approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did it pass any tests? Is this file unused or something?

@Steveb-p Steveb-p requested a review from a team May 18, 2022 07:42
@konradoboza konradoboza requested a review from a team May 18, 2022 07:43
@mikadamczyk mikadamczyk requested a review from a team May 18, 2022 07:58
@glye
Copy link
Member Author

glye commented May 18, 2022

How did it pass any tests? Is this file unused or something?

@Steveb-p Most likely. I found it when running tests manually, which I have to do because of reasons.

@glye glye merged commit 5e7941c into 7.5 May 19, 2022
@glye glye deleted the schema-syntax-error-defaul branch May 19, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@konradoboza konradoboza konradoboza approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

Labels
Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@glye @adamwojs @mikadamczyk @Steveb-p @konradoboza @alongosz