-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-32321: Added deleteTranslations target to fix 'content/remove' permission check #3084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
requested review from
alongosz,
ViniTou,
adamwojs,
kaff,
Steveb-p,
webhdx and
Nattfarinn
February 2, 2021 08:27
alongosz
requested changes
Feb 2, 2021
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/ContentServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/LocationServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
eZ/Publish/API/Repository/Tests/TrashServiceAuthorizationTest.php
Outdated
Show resolved
Hide resolved
alongosz
approved these changes
Feb 2, 2021
2 tasks
adamwojs
reviewed
Feb 2, 2021
...ish/API/Repository/Tests/Limitation/PermissionResolver/LanguageLimitationIntegrationTest.php
Outdated
Show resolved
Hide resolved
...ish/API/Repository/Tests/Limitation/PermissionResolver/LanguageLimitationIntegrationTest.php
Outdated
Show resolved
Hide resolved
...ish/API/Repository/Tests/Limitation/PermissionResolver/LanguageLimitationIntegrationTest.php
Outdated
Show resolved
Hide resolved
Nattfarinn
approved these changes
Feb 2, 2021
bogusez
approved these changes
Feb 5, 2021
Could you merge it up? |
This was referenced Mar 11, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.5
A bug occurs how long a policy
content/remove
has a language limitation. If 'initialLanguageCode' of content is the same as one of the allowed languages then the user can delete content. Because initial language code is set when content is edited in given language behavior is nondeterministic. To eliminate this bug additional "target" should be passed as an argument when the permission check I performed. After this change, if the user hascontent/remove
policy with language limitations then he has to have access to all languages of content.Documentation
After this change, if the user has
content/remove
policy with language limitations then he has to have access to all languages of content.Below is an example of how a permission check could be achieved
QA
TODO:
$ composer fix-cs
).