Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31735: As a Developer I'd like direct upgrade path from 1.13LTS to 2.5LTS #3048

Merged
merged 5 commits into from
Oct 15, 2020

Conversation

andrerom
Copy link
Contributor

@andrerom andrerom commented Jul 10, 2020

Question Answer
JIRA issue EZP-31735 As a Developer I'd like direct upgrade paths from LTS to LTS
Bug/Improvement yes
Target version 7.5
BC breaks no
Tests pass N/A
Doc needed yes (to reach goal of story)

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@andrerom andrerom requested a review from alongosz July 10, 2020 09:01
@andrerom andrerom changed the title EZP-31735: As a Developer I'd like direct upgrade paths from LTS to LTS EZP-31735: As a Developer I'd like direct upgrade path from LTS to LTS (6.13 => 7.5) Jul 10, 2020
@andrerom andrerom changed the title EZP-31735: As a Developer I'd like direct upgrade path from LTS to LTS (6.13 => 7.5) EZP-31735: As a Developer I'd like direct upgrade path from 1.13LTS to 2.5LTS Jul 10, 2020
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, if I understood your intention right, I would expect rather to-7.5.x.sql or to-7.5.latest.sql. It would be clear that this contains all the needed changes. Or is developer still expected to run all *-to-7.5.*.sql scripts?

Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark regarding the MySQL script itself:

data/update/mysql/dbupdate-6.13.0-to-7.5.7.sql Outdated Show resolved Hide resolved
@andrerom

This comment has been minimized.

@andrerom andrerom requested a review from alongosz August 24, 2020 12:59
@andrerom
Copy link
Contributor Author

Updated to go from 6.13.0 to 7.5.0 as the others. /cc @vidarl

@andrerom andrerom requested a review from glye September 3, 2020 11:45
data/update/mysql/dbupdate-5.4.0-to-6.13.0.sql Outdated Show resolved Hide resolved
data/update/postgres/dbupdate-6.13.0-to-7.5.0.sql Outdated Show resolved Hide resolved
@andrerom andrerom requested a review from vidarl September 4, 2020 13:49
@andrerom
Copy link
Contributor Author

@alongosz Better now? (It's now dbupdate-6.13.0-to-7.5.0.sql to eliminate any indications it will be kept updated for minor versions)

@vidarl
Copy link
Member

vidarl commented Oct 13, 2020

One thing though. dbupdate-6.13.0-to-7.5.0.sql doesn't mention anything in regards to dbupdate-7.1.0-to-7.2.0-dfs.sql. It should be mentioned in any doc page using dbupdate-6.13.0-to-7.5.0.sql that you'll also need to run dbupdate-7.1.0-to-7.2.0-dfs.sql if you're using cluster

@andrerom
Copy link
Contributor Author

@vidarl indeed it needs to be covered in doc as well so made note of it here: ibexa/documentation-developer#612

For the inline info in PR here it's ok or?

-- IMPORTANT:
-- * If you use DFS (cluster), also make sure to apply "dbupdate-7.1.0-to-7.2.0-dfs.sql"
-- * This only covers eZ Platform kernel, see doc for all steps (incl. database schema) needed when updating: https://doc.ezplatform.com/en/2.5/updating/updating_ez_platform/

@vidarl
Copy link
Member

vidarl commented Oct 14, 2020

For the inline info in PR here it's ok or?

Yeah, it's ok. ( I missed it when reviewing yesterday, but I see it's there now )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants