Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added conflict with phpunit/phpunit 8.4.0 #2800

Merged
merged 1 commit into from
Oct 4, 2019
Merged

Added conflict with phpunit/phpunit 8.4.0 #2800

merged 1 commit into from
Oct 4, 2019

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 4, 2019 •
edited
Loading

Question Answer
JIRA issue -
Bug/Improvement no
New feature no
Target version master for features
BC breaks no
Tests pass ?
Doc needed no

Added conflict with phpunit/phpunit v8.4.0 due to sebastianbergmann/phpunit#3879

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Oct 4, 2019
@adamwojs adamwojs requested review from alongosz and mnocon October 4, 2019 09:43
@adamwojs
Copy link
Member Author

adamwojs commented Oct 4, 2019

Unit tests are passing: https://travis-ci.org/ezsystems/ezpublish-kernel/jobs/593438024

@adamwojs adamwojs merged commit 65eb092 into master Oct 4, 2019
@adamwojs adamwojs deleted the conflict_with_phpunit_84 branch October 4, 2019 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@adamwojs adamwojs

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adamwojs @alongosz @mnocon