-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-31982: Revert cache setting in Encore config to default #602
Conversation
f989a28
to
7b87bb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, if Symfony default is "!kernel.debug", then this is indeed fine.
One Developer enablement request from me: we need commits that are being merged to be formed in past simple, since they're about to become a history. To simplify the process for a Maintainer, we're fine with forming a Pull Request title in the past as well, so a Maintainer can merge it as-is.
I know this is not the mainstream approach, just trying to keep consistency within the Product.
@alongosz agreed. To clarify, Symfony does not set that config value for environments other than ->booleanNode('cache')
->info('Enable caching of the entry point file(s)')
->defaultFalse()
->end() In production config files it is set to |
7b87bb9
to
a200c59
Compare
In practice disabled Encore built-in cache on dev environments, following Symfony's default configuration in this matter. Fixed an issue where adding new entrypoints to webpack.config.js caused them to not be recognized until cache was cleared - which lead to confusing errors on occuring on templates files that included those entrypoints.
a200c59
to
23d6b5a
Compare
You can merge it up. |
Done. |
@Steveb-p
This will make the doc team's work easier. |
JIRA: EZP-31982
This in practice disables Encore built-in cache on dev environments, following Symfony's default configuration in this matter.
Fixes an issue when adding new entrypoints to webpack.config.js that were not recognized until cache was cleared - which lead
to confusing errors occuring in template files that included those entrypoints.