Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-30386: [Alloy Editor] Custom Buttons #33

Merged
merged 3 commits into from
Apr 5, 2019
Merged

EZP-30386: [Alloy Editor] Custom Buttons #33

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8aa38d8
AlloyEditor Extra Buttons
SerheyDolgushev Apr 1, 2019
e8d5267
AlloyEditor Extra Buttons, mention that it will be deprecated in 3.x
SerheyDolgushev Apr 2, 2019
00a8a69
AlloyEditor Extra Buttons, fixing example
SerheyDolgushev Apr 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/bundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,16 @@ private function addCustomStylesSection(NodeBuilder $ezRichTextNode)
* ezpublish:
* ezrichtext:
* alloy_editor:
* extra_plugins: [plugin1, plugin2]
* extra_buttons:
* - paragraph: [button1, button2]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the hyphens should be removed, it doesn't work with hyphens. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micszo nice catch! Fixed in 00a8a69

* - embed: [button1]
* </code>
*
* Please note extra_buttons setting will be deprecated in eZ Platform 3.x.
* The alternative and more flexible solution will be introduced.
* So you will need to update Online Editor Extra Buttons as part of eZ Platform 3.x upgrade.
*
* @param \Symfony\Component\Config\Definition\Builder\NodeBuilder $ezRichTextNode
*
* @return \Symfony\Component\Config\Definition\Builder\ArrayNodeDefinition
Expand All @@ -183,6 +191,12 @@ private function addAlloyEditorSection(NodeBuilder $ezRichTextNode)
->example(['plugin1', 'plugin2'])
->prototype('scalar')->end()
->end()
->arrayNode('extra_buttons')
->arrayPrototype()
->example(['button1', 'button2'])
->prototype('scalar')->end()
->end()
->end()
->end()
->end()
;
Expand Down