Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-31641: Unable to manage links in table cells #149

Merged
merged 1 commit into from
May 21, 2020

Conversation

SerheyDolgushev
Copy link
Contributor

Question Answer
JIRA issue EZP-31641
Bug/Improvement yes
New feature no
Target version 2.0
BC breaks no
Tests pass yes
Doc needed no

Steps to reproduce

  1. Open for editing any content with RichText field in Admin UI
  2. Add an empty 3x3 table into the RichText field
  3. Type "test" In the first table cell
  4. Select typed text from the previous step, and make it link to "https://url.com"

Expected results
The cursor is moved to the next table cell and the toolbar for that cell is shown.

Actual results
The next table cell is selected, and the table cell toolbar is missing. The toolbar is not shown even if the user chooses any other table cell.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

Copy link
Member

@dew326 dew326 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some small CS.
The question is if this bug is also affects the 2.5, if so we should merge fix in admin-ui 1.5

@micszo micszo self-assigned this May 21, 2020
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE 3.0 with branch.

@micszo micszo removed their assignment May 21, 2020
@lserwatka lserwatka merged commit 0c598b7 into ezsystems:2.0 May 21, 2020
@lserwatka
Copy link
Member

@dew326 could you merge it up?

@dew326
Copy link
Member

dew326 commented May 21, 2020

Done

SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Jun 3, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Sep 29, 2020
@SerheyDolgushev SerheyDolgushev mentioned this pull request Sep 29, 2020
4 tasks
lserwatka pushed a commit that referenced this pull request Sep 30, 2020
* Fix related to #149

* Fix related to #163
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Oct 9, 2020
SerheyDolgushev added a commit to SerheyDolgushev/ezplatform-richtext that referenced this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants