Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-32255: Get rid of default DSF configuration (moved to Core) #152

Merged
merged 1 commit into from
Dec 31, 2020
Merged

EZP-32255: Get rid of default DSF configuration (moved to Core) #152

merged 1 commit into from
Dec 31, 2020

Conversation

Nattfarinn
Copy link
Contributor

Question Answer
JIRA issue EZP-32255
Type bug
Target eZ Platform version v3.3
BC breaks maybe
Doc needed no

Due to how are configurations loaded with Flex, we have to move configuration to where it is overwritten (EzPlatformCoreBundle).

Requires: ezsystems/ezplatform-core#29

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@Nattfarinn Nattfarinn requested review from alongosz and a team December 30, 2020 15:32
@Nattfarinn Nattfarinn mentioned this pull request Dec 30, 2020
Merged
@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micszo micszo self-assigned this Dec 30, 2020
@lserwatka lserwatka merged commit 7b329f8 into master Dec 31, 2020
@lserwatka lserwatka deleted the ezp-32255-dfs branch December 31, 2020 12:51
@micszo micszo removed their assignment Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alongosz alongosz alongosz approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nattfarinn @alongosz @lserwatka @micszo