Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32184: Added warning about possible memory leaks for reindex command #138

Merged
merged 5 commits into from
Dec 10, 2020

Conversation

konradoboza
Copy link
Member

@konradoboza konradoboza commented Nov 26, 2020

Question Answer
JIRA issue EZP-32184
Type improvement
Target eZ Platform version v3.1, v3.2
BC breaks no
Doc needed no

Excerpt from JIRA:

Under several circumstances (https://doc.ibexa.co/en/3.1/guide/performance/#reducing-memory-usage) there might be potential memory leaks while running ezplatform:reindex command against big databases. The idea is to put a proper warning explaining several of them.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@konradoboza konradoboza added Improvement Changes not fixing or changing behavior Ready for review labels Nov 26, 2020
@konradoboza konradoboza self-assigned this Nov 26, 2020
@andrerom
Copy link
Contributor

Hmm, confirmations are kind of annoying. Especially when we don't bother to check if user is actually about to run something that won't work very well that we warn against (check if xdebug is enabled + argument for only one process).

So either make this smarter, or maybe move to help text?

@konradoboza konradoboza changed the title EZP-32184: Added warning about possible memory leaks for reindex command [WIP] EZP-32184: Added warning about possible memory leaks for reindex command Dec 4, 2020
@konradoboza konradoboza changed the title [WIP] EZP-32184: Added warning about possible memory leaks for reindex command EZP-32184: Added warning about possible memory leaks for reindex command Dec 7, 2020
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza removed their assignment Dec 8, 2020
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform-ee 3.1.4 & 3.2.2 with patch.

@lserwatka lserwatka merged commit 8a50b15 into 1.1 Dec 10, 2020
@lserwatka lserwatka deleted the ezp-32184-reindex-command-warning branch December 10, 2020 14:18
Steveb-p pushed a commit that referenced this pull request Sep 27, 2022
Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Changes not fixing or changing behavior QA approved
Development

Successfully merging this pull request may close these issues.

8 participants