EZEE-3350: Added support to save additional data in ezImage FT #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViniTou
force-pushed
the
ezee-3350-store-image-data
branch
from
56aee4a
to
8c80c0c
Compare
ViniTou
requested review from
alongosz,
webhdx,
adamwojs,
kaff,
mikadamczyk,
Nattfarinn and
Steveb-p
adamwojs
approved these changes
Nov 20, 2020
eZ/Publish/Core/Persistence/Tests/Legacy/FieldValue/Converter/ImageConverterTest.php
Outdated
Show resolved
Hide resolved
…ImageConverterTest.php Co-authored-by: Adam Wójs <[email protected]>
2 tasks
alongosz
reviewed
Nov 30, 2020
eZ/Publish/Core/Persistence/Tests/Legacy/FieldValue/Converter/ImageConverterTest.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Dec 2, 2020
Comment on lines
+95
to
+105
| <<< XML | ||
| <?xml version="1.0" encoding="utf-8"?> | ||
| <ezimage serial_number="1" is_valid="1" filename="ibexa_fav.png" | ||
| suffix="png" basename="ibexa_fav" dirpath="{$dir}" url="{$pathToImg}" | ||
| original_filename="ibexa_fav.png" mime_type="image/png" width="100" | ||
| height="200" alternative_text="test" alias_key="1293033771" timestamp="{timestampToReplace}"> | ||
| <original attribute_id="1" attribute_version="1" attribute_language="eng-GB"/> | ||
| <information Height="200" Width="100" IsColor="1"/> | ||
| <additional_data><attribute key="focalPointX">50</attribute><attribute key="focalPointY">100</attribute><attribute key="author">John Smith</attribute></additional_data> | ||
| </ezimage> | ||
| XML, |
There was a problem hiding this comment.
https://wiki.php.net/rfc/flexible_heredoc_nowdoc_syntaxes
You can indent this, since we have PHP 7.3+ as dependency.
There was a problem hiding this comment.
I also thought we can do this, but it seems that indenting XMLs causes issues with linters as XML must start with declaration and not empty spaces.
|
Kudos, SonarCloud Quality Gate passed!
|
alongosz
approved these changes
Dec 2, 2020
tomaszszopinski
approved these changes
Dec 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v3.3As a part of image editor story, ezimage type must be able to save additional information with some related parameters. This opened up possibility to make it more versatile (and easier to maintain).
Checklist:
$ composer fix-cs).@ezsystems/php-dev-team).