Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31741: Fixed features detection in eZ\Publish\Core\Repository\SearchService::supports #113

Merged
merged 2 commits into from
Oct 13, 2020
Merged

EZP-31741: Fixed features detection in eZ\Publish\Core\Repository\SearchService::supports #113

merged 2 commits into from
Oct 13, 2020

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 23, 2020 •
edited
Loading

Question Answer
JIRA issue EZP-31741
Required by ezsystems/ezplatform-solr-search-engine#193 https://github.com/ezsystems/ezplatform-elastic-search-engine/pull/17
Type bug
Target eZ Platform version v3.1+
BC breaks no
Doc needed no

The following check

https://github.com/ezsystems/ezplatform-kernel/blob/1.1/eZ/Publish/Core/Repository/SearchService.php#L347-L349

will always fail because injected \eZ\Publish\SPI\Search\Handler is proxy object generated from interface instead of concrete class.

See also https://jira.ez.no/browse/EZP-31701

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@adamwojs adamwojs mentioned this pull request Sep 23, 2020
Closed
4 tasks
@adamwojs adamwojs added the Bug Something isn't working label Sep 23, 2020
@adamwojs adamwojs self-assigned this Sep 23, 2020
@adamwojs adamwojs mentioned this pull request Sep 23, 2020
Merged
@ezsystems ezsystems deleted a comment from sonarcloud bot Sep 23, 2020
@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo self-assigned this Sep 30, 2020
@micszo
Copy link
Member

micszo commented Oct 1, 2020

Test status in ezsystems/ezplatform-solr-search-engine#193 (comment) and https://github.com/ezsystems/ezplatform-elastic-search-engine/pull/17#issuecomment-702153266.

@micszo micszo removed their assignment Oct 13, 2020
@adamwojs adamwojs merged commit 33b9296 into 1.1 Oct 13, 2020
@adamwojs adamwojs deleted the ezp_31741v2 branch October 13, 2020 11:06
Steveb-p pushed a commit that referenced this pull request May 31, 2022
@adamwojs
Merge pull request #113 from ibexa/temp_1.3_to_4.1
550aa98 
Merge branch '1.3' of ezsystems/ezplatform-kernel into 4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaff kaff kaff approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

@micszo micszo micszo approved these changes

@ViniTou ViniTou ViniTou approved these changes

Assignees

@adamwojs adamwojs

Labels
Bug Something isn't working QA approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@adamwojs @micszo @kaff @mikadamczyk @alongosz @ViniTou