Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-32379: Deleted unusable thumbnail generation based on 'ezobjectrelation' #97

Merged
merged 1 commit into from
Mar 17, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Mar 8, 2021

Question Answer
JIRA issue EZP-32379
Type bug
Target eZ Platform version v3.2
BC breaks no
Doc needed no

As for now, thumbnails are not generated based on 'ezobjectrelation' field type. There is no such strategy (unlike for 'Image' or 'ImageAsset' - ezplatform-kernel/eZ/Publish/SPI/Repository/Strategy/ContentThumbnail/Field/FieldTypeBasedThumbnailStrategy), therefore the "is Thumbnail" field is disabled in case of 'ezobjectrelation'.

This PR fixes the infinite loop originating from the circular relation between two Content Types as well.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ezsystems/php-dev-team).

@barw4 barw4 added the Bug Something isn't working label Mar 8, 2021
@barw4 barw4 self-assigned this Mar 8, 2021
@barw4 barw4 requested review from bdunogier and a team March 8, 2021 13:03
@micszo micszo self-assigned this Mar 16, 2021
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Experience v3.2.5 with diff.

@micszo micszo removed their assignment Mar 17, 2021
@lserwatka lserwatka merged commit 8a9e814 into 2.2 Mar 17, 2021
@lserwatka lserwatka deleted the ezp-32379-fix-thumbnail-resolver branch March 17, 2021 14:34
@barw4
Copy link
Member Author

barw4 commented Mar 17, 2021

Merged into master: add8667

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Development

Successfully merging this pull request may close these issues.

8 participants