Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1565: Refactor schema's types' names validation #116

Merged
merged 5 commits into from
Dec 28, 2021
Merged

IBX-1565: Refactor schema's types' names validation #116

merged 5 commits into from
Dec 28, 2021

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Dec 3, 2021

Question Answer
JIRA issue IBX-1565
Type bug
Target version v2.5
BC breaks no

Content Type Groups don't have an identifier that matches the GraphQL standard, they have only names. Therefore the problem arises in every Group which has some special chars and the schema is not generated at all for them, even though the name would be transformed.

The validation should occur after the identifiers have been transformed according to the standard, not before. This solution also simplifies code and avoids repeats.

@barw4 barw4 added Bug Something isn't working Ready for review labels Dec 3, 2021
@barw4 barw4 self-assigned this Dec 3, 2021
@barw4 barw4 requested review from bdunogier and a team December 3, 2021 15:24
@konradoboza konradoboza requested review from adamwojs and a team December 9, 2021 07:35
@sonarcloud
Copy link

sonarcloud bot commented Dec 9, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

bdunogier
bdunogier approved these changes Dec 9, 2021
View reviewed changes
Copy link
Member

@bdunogier bdunogier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better than the previous approach, and more flexible since we can transform some other specific names that would right now be invalid.

@tomaszszopinski tomaszszopinski self-assigned this Dec 28, 2021
tomaszszopinski
tomaszszopinski approved these changes Dec 28, 2021
View reviewed changes
Copy link

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on eZPlatform 2.5.

@adamwojs adamwojs merged commit acb2428 into 1.0 Dec 28, 2021
@adamwojs adamwojs deleted the ibx-1565-fix-naming-validation branch December 28, 2021 12:33
@barw4 barw4 mentioned this pull request Dec 28, 2021
Merged
@barw4
Copy link
Member Author

barw4 commented Dec 28, 2021 •
edited
Loading

Merge into:
2.3: a56b2f4
ibexa/graphql/main: ibexa/graphql@54d14ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamwojs adamwojs adamwojs approved these changes

@bdunogier bdunogier bdunogier approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

Assignees

@barw4 barw4

@tomaszszopinski tomaszszopinski

Labels
Bug Something isn't working QA approved Ready for MERGE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @adamwojs @bdunogier @konradoboza @tomaszszopinski