Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EZP-31954: fix fatal error when no error target defined #34

Merged
merged 1 commit into from
Oct 6, 2020
Merged

EZP-31954: fix fatal error when no error target defined #34

merged 1 commit into from
Oct 6, 2020

Conversation

ITernovtsii
Copy link
Contributor

@ITernovtsii ITernovtsii commented Sep 25, 2020 •
edited by micszo
Loading

JIRA: https://jira.ez.no/browse/EZP-31954

In case of RichText XML validation fails, fatal error displayed:

Argument 2 passed to Symfony\Component\Validator\Util\PropertyPath::append() must be of the type string, null given, called in /app/vendor/ezsystems/ezplatform-content-forms/src/lib/Validator/Constraints/FieldValueValidator.php on line 92 [in vendor/symfony/validator/Util/PropertyPath.php:34]

related PR: ezsystems/ezplatform-richtext#164

@lserwatka
Copy link
Member

Does it affect only master branch?

@ITernovtsii ITernovtsii changed the base branch from master to 1.0 September 25, 2020 09:34
@ITernovtsii
Copy link
Contributor Author

no, switched to 1.0

@ITernovtsii ITernovtsii mentioned this pull request Sep 25, 2020
Merged
4 tasks
@lserwatka lserwatka merged commit 67ad193 into ezsystems:1.0 Oct 6, 2020
@lserwatka
Copy link
Member

@alongosz could you merge it up?

@alongosz
Copy link
Member

alongosz commented Oct 6, 2020

Merged up to 1.1 via 0c0819d and master via 2775467.

Thank you @ITernovtsiy 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lserwatka lserwatka lserwatka approved these changes

@adamwojs adamwojs adamwojs approved these changes

@alongosz alongosz alongosz approved these changes

@bogusez bogusez bogusez approved these changes

Assignees
No one assigned
Labels
QA approved Ready for QA
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ITernovtsii @lserwatka @alongosz @adamwojs @bogusez