-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-30344: Improved handling Language Limitation #934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikadamczyk
force-pushed
the
lookupLimitation
branch
from
March 28, 2019 10:25
302257d
to
c537959
Compare
14 tasks
mikadamczyk
force-pushed
the
lookupLimitation
branch
5 times, most recently
from
April 4, 2019 12:19
79483d9
to
79fff01
Compare
mikadamczyk
requested review from
dew326,
webhdx,
ViniTou,
adamwojs,
pawbuj and
sunpietro
April 4, 2019 12:20
adamwojs
reviewed
Apr 4, 2019
src/lib/Form/Type/ChoiceList/Loader/ContentEditTranslationChoiceLoader.php
Outdated
Show resolved
Hide resolved
src/lib/Form/Type/ChoiceList/Loader/ContentEditTranslationChoiceLoader.php
Show resolved
Hide resolved
mikadamczyk
force-pushed
the
lookupLimitation
branch
from
April 4, 2019 13:45
47ab997
to
6cda64a
Compare
alongosz
changed the title
EZP-30344: Implemented Translation Limitation
EZP-30344: Improved handling Language Limitation
Apr 4, 2019
alongosz
approved these changes
Apr 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nitpick:
dew326
requested changes
Apr 5, 2019
src/bundle/Resources/public/js/scripts/admin.version.edit.conflict.js
Outdated
Show resolved
Hide resolved
src/bundle/Resources/public/js/scripts/admin.version.edit.conflict.js
Outdated
Show resolved
Hide resolved
mikadamczyk
force-pushed
the
lookupLimitation
branch
from
April 5, 2019 08:17
1dfcf4b
to
e8aaa0e
Compare
dew326
approved these changes
Apr 10, 2019
ViniTou
approved these changes
Apr 10, 2019
alongosz
added a commit
that referenced
this pull request
Apr 17, 2019
Squashed commit of the following: commit 4fcbd4f Author: Jakub Brzegowski <[email protected]> Date: Mon Apr 15 15:53:39 2019 +0200 Add permission check in edit in Sub-items commit 2da5bb1 Author: Andrew Longosz <[email protected]> Date: Wed Apr 10 00:58:59 2019 +0200 EZP-30344: Enabled right sidebar edit button for translated Content Editing should be possible if Content is already translated. commit eb88416 Author: Mikołaj Adamczyk <[email protected]> Date: Fri Apr 5 15:05:53 2019 +0200 EZP-30344: Implemented Translation Limitation - target version builder commit e8aaa0e Author: Mikołaj Adamczyk <[email protected]> Date: Thu Apr 4 15:47:50 2019 +0200 EZP-30344: Implemented Translation Limitation - code review commit 6cda64a Author: Mikołaj Adamczyk <[email protected]> Date: Thu Apr 4 15:44:50 2019 +0200 EZP-30344: Implemented Translation Limitation - disable HTTP cache commit 79fff01 Author: Mikołaj Adamczyk <[email protected]> Date: Thu Mar 28 16:15:18 2019 +0100 EZP-30344: Implemented Translation Limitation - language limitation commit 9a56766 Author: Mikołaj Adamczyk <[email protected]> Date: Tue Mar 26 14:14:28 2019 +0100 EZP-30344: Implemented Translation Limitation
micszo
approved these changes
Apr 17, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editing should be possible if Content is already translated.
alongosz
force-pushed
the
lookupLimitation
branch
from
April 18, 2019 15:42
4fcbd4f
to
6eafee9
Compare
konradoboza
pushed a commit
to konradoboza/ezplatform-admin-ui
that referenced
this pull request
May 29, 2019
* Improved handling Language Limitation * Disabled HTTP cache for ContentController::checkEditPermissionAction * Enabled right sidebar edit button for translated Content Editing should be possible if Content is already translated. * Added permission check for edit button in Sub-items Co-authored-by: Jakub <[email protected]>
mateuszdebinski
pushed a commit
that referenced
this pull request
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves handling of
Language
Limitation based on logic implemented in ezsystems/ezpublish-kernel#2585Checklist:
$ composer fix-cs
)