Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EZP-30344: Improved handling Language Limitation #934

Merged
merged 4 commits into from
Apr 18, 2019

Conversation

mikadamczyk
Copy link
Contributor

@mikadamczyk mikadamczyk commented Mar 27, 2019

Question Answer
Tickets https://jira.ez.no/browse/EZP-30344
Requires ezsystems/ezpublish-kernel#2585
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

This PR improves handling of Language Limitation based on logic implemented in ezsystems/ezpublish-kernel#2585

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@alongosz alongosz changed the title EZP-30344: Implemented Translation Limitation EZP-30344: Improved handling Language Limitation Apr 4, 2019
Copy link
Member

@alongosz alongosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick:

src/lib/Menu/ContentEditRightSidebarBuilder.php Outdated Show resolved Hide resolved
@micszo micszo self-assigned this Apr 11, 2019
alongosz added a commit that referenced this pull request Apr 17, 2019
Squashed commit of the following:

commit 4fcbd4f
Author: Jakub Brzegowski <[email protected]>
Date:   Mon Apr 15 15:53:39 2019 +0200

    Add permission check in edit in Sub-items

commit 2da5bb1
Author: Andrew Longosz <[email protected]>
Date:   Wed Apr 10 00:58:59 2019 +0200

    EZP-30344: Enabled right sidebar edit button for translated Content

    Editing should be possible if Content is already translated.

commit eb88416
Author: Mikołaj Adamczyk <[email protected]>
Date:   Fri Apr 5 15:05:53 2019 +0200

    EZP-30344: Implemented Translation Limitation - target version builder

commit e8aaa0e
Author: Mikołaj Adamczyk <[email protected]>
Date:   Thu Apr 4 15:47:50 2019 +0200

    EZP-30344: Implemented Translation Limitation - code review

commit 6cda64a
Author: Mikołaj Adamczyk <[email protected]>
Date:   Thu Apr 4 15:44:50 2019 +0200

    EZP-30344: Implemented Translation Limitation - disable HTTP cache

commit 79fff01
Author: Mikołaj Adamczyk <[email protected]>
Date:   Thu Mar 28 16:15:18 2019 +0100

    EZP-30344: Implemented Translation Limitation - language limitation

commit 9a56766
Author: Mikołaj Adamczyk <[email protected]>
Date:   Tue Mar 26 14:14:28 2019 +0100

    EZP-30344: Implemented Translation Limitation
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micszo micszo removed their assignment Apr 17, 2019
@alongosz alongosz merged commit 1c52307 into ezsystems:master Apr 18, 2019
konradoboza pushed a commit to konradoboza/ezplatform-admin-ui that referenced this pull request May 29, 2019
* Improved handling Language Limitation

* Disabled HTTP cache for ContentController::checkEditPermissionAction

* Enabled right sidebar edit button for translated Content

Editing should be possible if Content is already translated.

* Added permission check for edit button in Sub-items

Co-authored-by: Jakub <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

7 participants