Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3320: Unified content versions edit buttons logic #2058

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

barw4
Copy link
Member

@barw4 barw4 commented Jul 20, 2022

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-3320
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Not sure about the desired behavior (right now we are forbidding from editing someone else's draft in the Back Office during conflict modal, unlike API - is this correct or should we allow it?) but the logic should be unified when it comes to version editing.

Related PR: https://github.com/ezsystems/ezplatform-page-builder/pull/961

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@barw4 barw4 requested a review from a team July 20, 2022 13:56
@barw4 barw4 self-assigned this Jul 20, 2022
@barw4 barw4 changed the title IBX-3320: Unified content versions edit button logic IBX-3320: Unified content versions edit buttons logic Jul 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ViniTou ViniTou requested a review from a team August 22, 2022 10:22
@konradoboza konradoboza requested a review from a team August 22, 2022 10:28
@micszo micszo removed their assignment Aug 23, 2022
@mikadamczyk mikadamczyk merged commit 1e0ce8c into 2.3 Aug 23, 2022
@mikadamczyk mikadamczyk deleted the ibx-3320-version-edit-unification branch August 23, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

9 participants