Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-159: Added pagination in locations tab #1735

Merged
merged 8 commits into from
Apr 14, 2021

Conversation

mateuszdebinski
Copy link
Contributor

@mateuszdebinski mateuszdebinski commented Apr 8, 2021

Question Answer
Tickets IBX-159
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@mateuszdebinski mateuszdebinski marked this pull request as ready for review April 8, 2021 15:08
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/bundle/Resources/config/services/tabs/locationview.yml Outdated Show resolved Hide resolved
src/bundle/Resources/config/services/tabs/locationview.yml Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/bundle/Resources/config/services/tabs/locationview.yml Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/LocationsTab.php Outdated Show resolved Hide resolved
src/lib/Tab/LocationView/PagerLocationToDataMapper.php Outdated Show resolved Hide resolved
Copy link
Member

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on eZ Platform EE 2.5 with diff.

Side, while at it stumbled upon 10 year old issue with sending to trash of times with multiple locations: https://issues.ibexa.co/browse/EZP-18871.

@micszo micszo removed their assignment Apr 14, 2021
@lserwatka lserwatka merged commit 9e79a93 into 1.5 Apr 14, 2021
@lserwatka lserwatka deleted the IBX-159-adding-pagination-location-lists branch April 14, 2021 11:20
@lserwatka
Copy link
Member

Could you merge it up?

lucasOsti pushed a commit to lucasOsti/ezplatform-admin-ui that referenced this pull request Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

8 participants