Add tab to adminUI to display comments

[dspe]

First step to bring it back CommentsBundle into eZ Platform UI (v2 Admin UI)

[bdunogier]

Good changes, but the requirements need to be clarified. You have a service and a class that depend on admin-ui, since it extends EzSystems\EzPlatformAdminUi\Tab\AbstractTab. It means that this patch requires v2.

Maybe this could be kept compatible with v1 & v2 by only moving the tab service to a v2 dedicated file, and only load it when admin-ui is installed ?

[dspe]

Indeed @bdunogier . I will check maybe with the PM first to know if we keep BC or if we could break it to a new version .

[bdunogier]

After discussing the matter with @dspe, we decided to go for v1 & v2 compatibility by only load the admin related services if ezplatform-admin-ui is installed.

[dspe]

Small update. maybe something better to do ? @bdunogier any feedbacks? and how to fix Travis too ?

[alongosz]

I missed that review request, better late than never. But... well... Guys... I'm very sorry... -1 on this approach from my side. This is anti-pattern.

I know you neither agree with nor like my perspective, so not going to request changes. Just making a comment that you're free to ignore:

[andrerom]

👍

Aslo merged in style fixes and updates in master, so ready for last review now, so unless there is some nitpick new style rule failing on the new code Travis should be expected to be green now 📗

[alongosz]

Looks good.
Nitpicks:

[andrerom]

Released v7.0.0-beta1 for those that want to test this.

@bdunogier / @SylvainGuittard Maybe you can schedule this being added in upcoming 2.5.x demo / ee-demo release => so QA has a way to test this => so it can reach stable?

[SylvainGuittard]

Thanks @andrerom
👍