Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check: false isn't working in watch mode #82

Closed
marijnh opened this issue Jun 1, 2018 · 2 comments
Closed

check: false isn't working in watch mode #82

marijnh opened this issue Jun 1, 2018 · 2 comments
Assignees
Labels
kind: bug Something isn't working properly scope: watch mode Related to Rollup's watch mode

Comments

@marijnh
Copy link
Contributor

marijnh commented Jun 1, 2018

What happens and why it is wrong

When I configure the plugin to not check, but run rollup with -w checking seems to still be taking place (I get errors, and the build is no faster than with check: true).

Versions

Version 0.14.0, TypeScript 2.8.4, Rollup 0.56.5.

rollup.config.js

import typescript from "rollup-plugin-typescript2";
import commonjs from "rollup-plugin-commonjs"

export default {
  input: "./view/test/test.ts",
  output: {
    format: "umd",
    file: "./view/test/test_built.js",
    sourcemap: false
  },
  plugins: [
    typescript({
      check: false,
      tsconfigOverride: {
        compilerOptions: {lib: ["ES6", "dom"], sourceMap: false, target: "es5", strict: false},
        include: null
      }
    }),
    commonjs()
  ]
}

tsconfig.json

{
  "compilerOptions": {
    "lib": ["ES6", "dom"],
    "noImplicitReturns": true,
    "noUnusedLocals": true,
    "sourceMap": true,
    "strict": true,
    "target": "es5"
  },
  "include": ["*/src/*.ts"]
}
@ezolenko ezolenko self-assigned this Jun 4, 2018
ezolenko added a commit that referenced this issue Jun 4, 2018
- printing tslib version
@ezolenko
Copy link
Owner

ezolenko commented Jun 4, 2018

Forgot to check that option in watch mode... :) Could you check if master works for you? @marijnh

I'll do a release sometime this week.

@marijnh
Copy link
Contributor Author

marijnh commented Jun 5, 2018

Yes! Thanks for the fix. (For some reason, it's still not nearly as fast as rollup-typescript, but clearly better than before.)

@marijnh marijnh closed this as completed Jun 5, 2018
@agilgur5 agilgur5 changed the title check: false isn't working in watch mode check: false isn't working in watch mode May 22, 2022
@agilgur5 agilgur5 added the kind: bug Something isn't working properly label May 22, 2022
Repository owner locked as resolved and limited conversation to collaborators May 22, 2022
@agilgur5 agilgur5 added the scope: watch mode Related to Rollup's watch mode label Jun 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind: bug Something isn't working properly scope: watch mode Related to Rollup's watch mode
Projects
None yet
Development

No branches or pull requests

3 participants