rpt2 not ignoring *.d.cts and *.d.mts files (resulting in Unexpected token error)
#446
Labels
Comments
phun-ky
changed the title
*.d.cts' or *.d.mts`-files
|
Perhaps this is relevant: rollup/plugins#1480 |
agilgur5
changed the title
*.d.cts' or *.d.mts`-filesUnexpected token when importing *.d.cts or *.d.mts files
|
So declaration files are not supposed to be directly imported in TS. TS picks them up without imports. See #273 for some more details. |
|
@agilgur5 well, that kind of goes without saying :) but I am not including the declaration files directly, nor is |
|
@phun-ky try explicitly including d.cts and d.mts: include: [ "*.ts+(|x)", "**/*.ts+(|x)", '**/*.d.cts', '**/*.d.mts' ]This will run them through typescript and I guess produce empty js. Somehow |
|
Ah, ignore that -- this fixes the problem: include: [ "*.ts+(|x)", "**/*.ts+(|x)", '**/*.cts', '**/*.mts' ] |
ezolenko
added a commit
that referenced
this issue
May 19, 2023
|
@phun-ky could you try building your whole repo with master branch of the plugin? |
|
@ezolenko still got issues, sorry for the late reply! /home/alexander/Workspace/knowit/internal/devplatform-server-api/packages/middlewares/csp/src/index.ts → dist...
[!] (plugin rpt2) RollupError: Unexpected token (Note that you need plugins to import files that are not JavaScript)
../../../node_modules/helmet/index.d.cts (3:5)
1: import {IncomingMessage, ServerResponse} from "http"
2:
3: type ContentSecurityPolicyDirectiveValueFunction = (req: IncomingMessage, res: ServerResponse) => string
^
4: type ContentSecurityPolicyDirectiveValue = string | ContentSecurityPolicyDirectiveValueFunction
5: interface ContentSecurityPolicyOptions {
at error (/usr/local/lib/node_modules/rollup/dist/shared/rollup.js:279:30)
at Module.error (/usr/local/lib/node_modules/rollup/dist/shared/rollup.js:13933:16)
at Module.tryParse (/usr/local/lib/node_modules/rollup/dist/shared/rollup.js:14644:25)
at Module.setSource (/usr/local/lib/node_modules/rollup/dist/shared/rollup.js:14246:39)
at ModuleLoader.addModuleSource (/usr/local/lib/node_modules/rollup/dist/shared/rollup.js:24211:20)
|
|
@phun-ky could you post verbose output when building with master branch and your rollup config if different from what you already posted? |
|
Here is the verbose output,
npm run build |
|
So this run succeeded? Try doing a clean build |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
What's weird is that this works like a charm: $ ts-node --esm --project tsconfig.json src/index.ts |
|
Any progress on this issue? :) |
This was referenced Jun 19, 2023
Merged
|
@phun-ky the progress is slow :) Could you try Your example project compiles for me on that branch. |
|
@ezolenko yep! that worked like a charm! |
|
Ok, I'll make a release with the last few fixes |
|
In 0.35.0 now |
|
@ezolenko thanks for the great work! I really appreciate it! |
agilgur5
added
kind: feature
Ah, sorry for not checking this in more depth earlier! Was on my phone and just responded real quick to the title. We've had a lot of folks trying to import Glad that ezolenko had some time to spare and could help in more depth that same day! root cause analysis
So I did root cause this as I was curious how the heck that happened as that's definitely not correct behavior. Took me a bit to find Helmet's That is to say, the irony of incomplete branchesIn a bout of extreme irony, when I looked at my local code, I actually already had a similar line there 😵💫🤔 It turns out while I was attempting to fix #426 back in October (never quite finished that, partly because I was having trouble with Rollup ESM config), I made this commit on one of my branches containing the exact same line 😅 |
agilgur5
changed the title
Unexpected token when importing *.d.cts or *.d.mts files*.d.cts and *.d.mts files (resulting in Unexpected token error)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Troubleshooting
Does
tschave the same output? If so, please explain why this is incorrect behaviorN/A
Does your Rollup plugin order match this plugin's compatibility? If not, please elaborate
yes
Can you create a minimal example that reproduces this behavior? Preferably, use this environment for your reproduction
https://stackblitz.com/edit/rpt2-repro-3j5vny?file=src%2Findex.ts,package.json,src%2Flib%2Findex.ts,README.md,tsconfig.json
What happens and why it is incorrect
Error is thrown, should have support for
*.cts/*.mtsfilesEnvironment
Ubuntu 22.04
Versions
:rollup.config.js
:tsconfig.json
:package.json{ "name": "@kilabs/devplatform-server-api", "type": "module", "private": true, "version": "0.0.1", "description": "The API monorepo for the devplatform", "scripts": { "test": "echo \"Error: no test specified\" && exit 1", "commit": "npx git-cz" }, "author": "Alexander Vassbotn Røyne-Helgesen <[email protected]>", "license": "SEE LICENSE IN LICENSE", "devDependencies": { "@rollup/plugin-commonjs": "^24.1.0", "@rollup/plugin-json": "^6.0.0", "@rollup/plugin-node-resolve": "^15.0.2", "@rollup/plugin-terser": "^0.4.1", "@types/express": "^4.17.17", "@typescript-eslint/eslint-plugin": "^5.54.1", "@typescript-eslint/parser": "^5.54.1", "eslint": "^8.25.0", "eslint-config-airbnb": "^19.0.4", "eslint-config-prettier": "^8.5.0", "eslint-plugin-compat": "^4.1.2", "eslint-plugin-import": "^2.27.5", "eslint-plugin-prettier": "^4.2.1", "lerna": "^6.6.2", "prettier": "^2.7.1", "prettier-eslint": "^15.0.1", "rollup": "^3.22.0", "rollup-plugin-dts": "^5.3.0", "rollup-plugin-node-externals": "^6.0.1", "rollup-plugin-typescript2": "^0.34.1", "tslib": "^2.3.1", "typescript": "^5.0.4" }, "workspaces": [ "utils/*", "routes/*", "middlewares/*" ] }The text was updated successfully, but these errors were encountered: