Fix ci breaking due to new dependencies and rustc changes #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ten3roberts
force-pushed
the
test-ci
branch
3 times, most recently
from
a5e77da
to
5c30dd9
Compare
ten3roberts
changed the title
ten3roberts
force-pushed
the
test-ci
branch
3 times, most recently
from
16a3a8a
to
f81c492
Compare
|
Failing on windows due to an extra function call before main (in Rust) on windows only |
ten3roberts
changed the title
thenorili
approved these changes
Mar 28, 2024
| @@ -168,7 +170,7 @@ fn test_backwards_compatibility(target: String, file_name: &str) { | |||
| fn normalize_backtrace(input: &str) -> String { | |||
| input | |||
| .lines() | |||
| .take_while(|v| !v.contains("core::panic")) | |||
| .take_while(|v| !v.contains("core::panic") && !v.contains("theme_test_helper::main")) | |||
There was a problem hiding this comment.
This is ignoring a specific kind of panic from theme_test_helper, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.