Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Except doc files from CI runs #128

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thenorili
Copy link
Contributor

@thenorili thenorili commented Dec 1, 2023

Running CI over changing the README is a waste! I just tested this in a personal repo of mine and was delighted that it works. I can't demonstrate that it works in this pull request 'on pull request' considers all files changed in the PR and this change necessarily changes the ci.yml, but I can show where it's worked elsewhere.

Note this isn't compatible with the "Require status checks to pass before merging" branch protection setting. I wasn't sure if we used that, but it looks like we do have a number of required checks that this would cause trouble for -- the CI wouldn't run automatically, so docs PRs would be left stuck.

Running CI over changing the README is a waste! I just tested this in a
personal repo of mine and was delighted that it works. I can't
demonstrate that it works in this pull request 'on pull request'
considers all files changed in the PR and this change necessarily
changes the ci.yml, but I can show where it's worked elsewhere.
@thenorili thenorili marked this pull request as draft December 1, 2023 11:21
@thenorili
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant