-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to the new backtrace API #124
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comparison to a test working normally:
produces
|
Even if I set up gag to grab the output during this panic, I don't see how to keep getting that output with a panic handler that's been modified not to panic so that I can go on to test the output. I'm going to look at how std backtrace writes their unit tests. |
thenorili
force-pushed
the
97-2-issue
branch
2 times, most recently
from
November 20, 2023 07:50
7bb9083
to
68a2624
Compare
thenorili
force-pushed
the
97-2-issue
branch
from
November 26, 2023 05:03
68a2624
to
29d17b5
Compare
We fixed backtrace in #160 and determined that the UI test isn't a realistic goal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses Issue #97. Pardon the half-baked commit message for now, I'll write it out more thoroughly once it's ready. I wrote a minimal test that produces error and panic backtraces, where I'm struggling is capturing this output and comparing it to a snippet. Comparing an error backtrace seems really difficult without intercepting stderr with something like Gag, which I'd prefer to avoid. Comparing the panic backtrace seems promising but the panic hook I added is only sending me the actual panic text -- ie panic!("foo") -> foo.
trying for an error backtrace like..
returns "panicked while processing panic", aka the payload downcast returned None.