Avoid filename collision in the monorepo structure #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: output filename collision appears in both stable and nightly builds. It's slightly more impactful than just a warning. Running cargo +nightly test, cargo test, cargo +nightly test in windows produces a linker error where color-spantrace tries to use eyre's usage.exe, see error 2 below. It's worked around pretty easily with cargo clean, but it's a problem that might get worse as the monorepo effort expands! This patch renames `usage.rs` to `CRATENAME-usage.rs`. Issue eyre-rs#115
pksunkara
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: output filename collision appears in both stable and nightly builds.It's slightly more impactful than just a warning. Running
cargo +nightly test,cargo test,cargo +nightly testin windows produces a linker error where color-spantrace tries to use eyre's usage.exe, see error 2 below. It's worked around pretty easily withcargo clean, but it's a problem that could get worse as the monorepo effort expands!This patch renames
usage.rstoCRATENAME-usage.rs.Issue #115