Update future-incompat pyo3 dependency #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that the tests with the pyo3 feature are failing here, let me check that locally and send another diff : ) |
thenorili
force-pushed
the
pyo3-future-incompat
branch
from
899016c
to
c6ebe7e
Compare
|
I'll make sure to check relevant features before pushing in the future! looks like pyo3 just renamed pvalue->value in 0.16.0 |
pksunkara
approved these changes
Nov 10, 2023
pyo3 v0.13.2 is tripping future-incompat. This change updates it to the newest 0.20. pyo3 v0.16.0 renamed pvalue -> value. The other future-incompat dependency, nom, is an indirect dependency through ansi-parser. See issue 116
pksunkara
force-pushed
the
pyo3-future-incompat
branch
from
c6ebe7e
to
cadf826
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyo3 v0.13.2 is tripping future-incompat. This change updates it to the newest 0.20.
The other future-incompat dependency, nom, is an indirect dependency through ansi-parser.
See issue #116