Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 500 error when opening leaderboard (in preview mode) #940

Merged
merged 1 commit into from
Sep 25, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions core/frameworks/pixel/components/table.ex
Original file line number Diff line number Diff line change
Expand Up @@ -67,8 +67,12 @@ defmodule Frameworks.Pixel.Table do

def cell(%{layout: layout, content: content} = assigns) do
layout =
if layout.type == :href and not valid_url?(content) do
%{layout | type: :string}
if layout.type == :href do
if valid_url?(content) do
layout
else
%{layout | type: :string}
end
else
layout
end
Expand Down Expand Up @@ -115,8 +119,10 @@ defmodule Frameworks.Pixel.Table do
"""
end

defp valid_url?(string) do
defp valid_url?(string) when is_binary(string) do
uri = URI.parse(string)
uri.scheme != nil && uri.host =~ "."
end

defp valid_url?(_), do: false
end
Loading