Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to logon as researcher after participating as participant #963

Closed
TjerkNan opened this issue Sep 16, 2024 · 5 comments
Closed

Unable to logon as researcher after participating as participant #963

TjerkNan opened this issue Sep 16, 2024 · 5 comments
Assignees

Comments

@TjerkNan
Copy link
Collaborator

Describe the bug
After you particpate in a data donation flow, you are unable to access the Sign in button on the top right.
When you access the actual url /user/sigin 'nothing happens'.

Closing the browser application or using a private window circumvents this issue.

To Reproduce
Steps to reproduce the behavior:

  1. Participate in data donation flow
  2. Observe that Signin button is gone
  3. Observe that /usr/signin isn't working.

Expected behavior
Sign in always works.

Screenshots
Screenshot 2024-09-16 at 11 57 45

Smartphone (please complete the following information):
All Browsers

@mellelieuwes
Copy link
Contributor

@TjerkNan The participant is an anonymous user that is technically signed in. This is by design.

You can log out the participant by going to /user/profile.

Does this help?

@TjerkNan
Copy link
Collaborator Author

@mellelieuwes yes that workaround works indeed. So should the solution be that we instruct/document this behaviour?

@mellelieuwes
Copy link
Contributor

@TjerkNan profile/logout is a hidden participant feature to not distract the participant. The participant does not need to logout.

So it is only needed when a creator tests the (anonymous) participant flow and want to go back to the creator account on the same browser.

Sometimes clients have this issue when testing the flow.

Do you have a suggestion where to document it? Or change the UX so it can be prevented?

@mellelieuwes
Copy link
Contributor

@TjerkNan I have fixed this issue by remove the user from the session when:

  • User is external user (anonymous)
  • Request path is outside of external user space. Only /assignment/<number> considered is a valid request path.

This means If you now click on the top left Next logo (opens home page) or manually go to for example /project or /user/signin the anonymous participant is signed out out first.

@TjerkNan
Copy link
Collaborator Author

After donating as anonymous, the sign-in page is visible again after clicking on next logo. As a participant being logged in it works too, but I will be logged out, seems OK to me.

@github-project-automation github-project-automation bot moved this from In review to Done in Link Panl Integration Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants