Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In development environment, prevent passwordhashes from being logged #844

Closed
TjerkNan opened this issue Jun 6, 2024 · 2 comments
Closed
Assignees

Comments

@TjerkNan
Copy link
Collaborator

TjerkNan commented Jun 6, 2024

Describe the bug
Best not to log user account password hashes in debug mode.

To Reproduce
I observed this issue when I discovered #843

Expected behavior
User account password hash is not shown in logs

Screenshots
Example is shared 'elsewhere'.

Desktop (please complete the following information):

  • Safari
@mellelieuwes
Copy link
Contributor

@TjerkNan ik heb het denk ik gefixed maar weet niet zeker of dat in jou use case zo is.

@mellelieuwes mellelieuwes moved this from In progress to In review in Link Panl Integration Jun 10, 2024
@TjerkNan
Copy link
Collaborator Author

I should have described better how to trigger this issue, but if I visit the leaderboard, I get logging but no sensitive data.

@github-project-automation github-project-automation bot moved this from In review to Done in Link Panl Integration Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants