Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"npm run release" updates release.zip if it already exists #14

Closed
kasperwelbers opened this issue Feb 9, 2024 · 1 comment · Fixed by #15
Closed

"npm run release" updates release.zip if it already exists #14

kasperwelbers opened this issue Feb 9, 2024 · 1 comment · Fixed by #15
Assignees

Comments

@kasperwelbers
Copy link
Contributor

When you make a new release with "npm run release", and release.zip already exists, it updates the zip folder instead of overwriting it.

As a result, you can end up with multiple versions of your build inside release.zip, and you might not see any updates when uploading the new version to Next. I also had some weird errors with loading web workers, that was (somehow) resolved after removing the old versions.

Specifically, the problem is in package.json, inside:
"archive": "cd build && zip -r ../release.zip .",

release.zip should be overwritten, not updated.

@mellelieuwes mellelieuwes self-assigned this Feb 9, 2024
@mellelieuwes
Copy link
Contributor

mellelieuwes commented Feb 9, 2024

Thanx for reporting this issue. I will fix this and think of a solution with some sort of release nr

@mellelieuwes mellelieuwes linked a pull request Feb 15, 2024 that will close this issue
mellelieuwes added a commit that referenced this issue Feb 16, 2024
Improved release script, see issue #14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants