Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optional::value_or() doesn't return a value #676

Open
eyalroz opened this issue Sep 7, 2024 · 0 comments
Open

optional::value_or() doesn't return a value #676

eyalroz opened this issue Sep 7, 2024 · 0 comments
Assignees
@eyalroz
Labels
bug resolved-on-development

Comments

@eyalroz
Copy link
Owner

eyalroz commented Sep 7, 2024

Our implementation of optional for pre-C++17 has a bug: optional<T>::value_or() doesn't return a value :-(
@eyalroz eyalroz added the bug label Sep 7, 2024
@eyalroz eyalroz self-assigned this Sep 7, 2024
eyalroz added a commit that referenced this issue Sep 7, 2024
@eyalroz
Fixes #676: Was not returning a value from optional::value_or() in …
fd49e5a 
…our optional implementation for pre-C++17 compilation
eyalroz added a commit that referenced this issue Sep 10, 2024
@eyalroz
Fixes #676: Was not returning a value from optional::value_or() in …
b1ef7f0 
…our optional implementation for pre-C++17 compilation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
bug resolved-on-development
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz