Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the range_attribute_t and advice code #640

Closed
eyalroz opened this issue Apr 12, 2024 · 0 comments
Closed

Rework the range_attribute_t and advice code #640

eyalroz opened this issue Apr 12, 2024 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Apr 12, 2024

Managed memory "ranges" have "attributes" in CUDA. But our class name for "ranges" of memory - managed or otherwise - is memory::managed::region_t. Also - it's not obvious we should even expose these "attribute" and "advice" types, at all; perhaps we can just keep them within detail_. Some refactoring seems to be in order.

@eyalroz eyalroz added the task label Apr 12, 2024
@eyalroz eyalroz changed the title Rename range_attribute_t to come in line with our memory::region_t class Rework the range_attribute_t and advice code Apr 19, 2024
eyalroz added a commit that referenced this issue Apr 20, 2024
* The user no longer sees `range_attribute_t` nor `advice_t` anywhere, they're within `detail_`
* Using a range namespace (although it's mostly for the `detail_` subnamespace), with `advice_t` and `attribute_t` types
* Now have a proper implementation of a setter for device-inspecific attributes
* Removed some redundant code
eyalroz added a commit that referenced this issue Apr 29, 2024
* The user no longer sees `range_attribute_t` nor `advice_t` anywhere, they're within `detail_`
* Using a range namespace (although it's mostly for the `detail_` subnamespace), with `advice_t` and `attribute_t` types
* Now have a proper implementation of a setter for device-inspecific attributes
* Removed some redundant code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant