-
-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Robustify" the RTC buffer getters (log, ptx, lto_ir) #609
Labels
Comments
eyalroz
added a commit
that referenced
this issue
Mar 10, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
eyalroz
added a commit
that referenced
this issue
Mar 11, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
eyalroz
added a commit
that referenced
this issue
Mar 11, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
eyalroz
added a commit
that referenced
this issue
Mar 18, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
eyalroz
added a commit
that referenced
this issue
Mar 29, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
eyalroz
added a commit
that referenced
this issue
Apr 20, 2024
…td::vector<T>`'s, effectively) with `cuda::unique_span<T>`'s, and make sure they're padded by an extra allocated character set to '\0'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the opportunity of our API for buffer getters in the RTC program output changing from the not-really-dynarray to a span, let's also make sure all of the actual-text-strings there are put in buffers with a trailing '\0'. This is not strictly necessary, as a span is not guaranteed to also work as a C-style, nul-terminated string - but it's safer if we do that, in case someone mishandles the returned container and treats its data like that.
The text was updated successfully, but these errors were encountered: