Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have the global-device-memory versions of make_unique and make_unique_region be the default #585

Closed
eyalroz opened this issue Feb 11, 2024 · 0 comments

Comments

@eyalroz
Copy link
Owner

eyalroz commented Feb 11, 2024

Right now, we don't accept cuda::memory::make_unique<T>, nor cuda::memory::make_unique_region - you have to use a subnamespace - one of device::, host:: or managed::. But - if you say:

cuda::memory::make_unique_region(my_device, 1234);

it's pretty obvious you want plain vanilla device-side memory. So, let's accept that.

eyalroz added a commit that referenced this issue Feb 12, 2024
eyalroz added a commit that referenced this issue Feb 12, 2024
eyalroz added a commit that referenced this issue Feb 29, 2024
@eyalroz eyalroz closed this as completed in 5c0e4f7 Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant