Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have all launch config validation code in single place #548

Closed
eyalroz opened this issue Oct 7, 2023 · 0 comments
Closed

Have all launch config validation code in single place #548

eyalroz opened this issue Oct 7, 2023 · 0 comments
Assignees
@eyalroz
Labels
resolved-on-development task

Comments

@eyalroz
Copy link
Owner

eyalroz commented Oct 7, 2023

We currently have a bit of validation code in the launch config / kernel launch headers, and more of it in the launch config builder class code. Let's put as much of this code in a single place and avoid duplication.
@eyalroz eyalroz added the task label Oct 7, 2023
@eyalroz eyalroz self-assigned this Oct 7, 2023
eyalroz added a commit that referenced this issue Oct 7, 2023
@eyalroz
Fixes #547, fixes #548, fixes #549: Launch configurtation validation …
148f9f9 
…code revamp

* Validation code is now consolidated in `launch_config.hpp` and the multi-pwrapper implementations file
* Now performing more validation at more opportunities before kernel launch
* Now ensuring the launch config dimensions don't result in 0-volumne
eyalroz added a commit that referenced this issue Oct 7, 2023
@eyalroz
Fixes #547, fixes #548, fixes #549: Launch configurtation validation …
6afee76 
…code revamp

* Validation code is now consolidated in `launch_config.hpp` and the multi-pwrapper implementations file
* Now performing more validation at more opportunities before kernel launch
* Now ensuring the launch config dimensions don't result in 0-volumne
* Now using `get_attribute()` for the device-level maximum shared memory per block, rather than getting all properties
eyalroz added a commit that referenced this issue Oct 7, 2023
@eyalroz
Fixes #547, fixes #548, fixes #549: Launch configurtation validation …
9fcb812 
…code revamp

* Validation code is now consolidated in `launch_config.hpp` and the multi-pwrapper implementations file
* Now performing more validation at more opportunities before kernel launch
* Now ensuring the launch config dimensions don't result in 0-volumne
* Now using `get_attribute()` for the device-level maximum shared memory per block, rather than getting all properties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eyalroz eyalroz

Labels
resolved-on-development task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eyalroz